Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: Style/Documentation: Exclude lib/mysql2/result.rb. #1295

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

junaruga
Copy link
Contributor

The issue was detected at #1293 (comment) .

The rubocop 1.41.1 complained with the message below. This commit suppresses the message, and makes the CI pass.

https://github.com/brianmario/mysql2/actions/runs/3758719510/jobs/6387395566#step:4:12

 lib/mysql2/result.rb:2:3: C: Style/Documentation: Missing top-level documentation comment for class Mysql2::Result.
  class Result
  ^^^^^^^^^^^^

@junaruga junaruga marked this pull request as ready for review December 22, 2022 21:41
The rubocop 1.41.1 complained with the message below. This commit suppresses the
message, and makes the CI pass.

https://github.com/brianmario/mysql2/actions/runs/3758719510/jobs/6387395566#step:4:12
```
 lib/mysql2/result.rb:2:3: C: Style/Documentation: Missing top-level documentation comment for class Mysql2::Result.
  class Result
  ^^^^^^^^^^^^
```
@junaruga junaruga force-pushed the wip/rubocop-style-result branch from 427ec6c to ec13a42 Compare December 22, 2022 21:54
@sodabrew
Copy link
Collaborator

lgtm!

@sodabrew sodabrew merged commit 0299c42 into brianmario:master Dec 23, 2022
@junaruga junaruga deleted the wip/rubocop-style-result branch December 23, 2022 00:34
@junaruga
Copy link
Contributor Author

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants